Skip to content
This repository was archived by the owner on May 22, 2026. It is now read-only.

reformat api-version into next link if its a client param - #1309

Merged
iscai-msft merged 12 commits into
autorestv3from
tack_on_api_version_paging
Jun 22, 2022
Merged

reformat api-version into next link if its a client param#1309
iscai-msft merged 12 commits into
autorestv3from
tack_on_api_version_paging

Conversation

@iscai-msft

@iscai-msft iscai-msft commented Jun 17, 2022

Copy link
Copy Markdown
Member

query_str = ""
next_link_str = "next_link"
try:
api_version_param = next(

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm adding api version if it's a client parameter, even if it's not explicitly listed as a parameter for that operation. lmk thoughts about that. Thanks!

@iscai-msft

Copy link
Copy Markdown
Member Author

/azp run autorest.python - ci

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@iscai-msft
iscai-msft merged commit d2dc4f3 into autorestv3 Jun 22, 2022
@iscai-msft
iscai-msft deleted the tack_on_api_version_paging branch June 22, 2022 20:28
iscai-msft added a commit that referenced this pull request Jun 22, 2022
…into dont_generate_maxpagesize

* 'autorestv3' of https://github.com/Azure/autorest.python:
  reformat api-version into next link if its a client param (#1309)
iscai-msft added a commit that referenced this pull request Jun 23, 2022
…into full_pipeline_cadl

* 'autorestv3' of https://github.com/Azure/autorest.python: (35 commits)
  nosec bandit code (#1324)
  pin isodate to major version (#1321)
  Dont generate maxpagesize (#1320)
  reformat api-version into next link if its a client param (#1309)
  Update ChangeLog.md (#1310)
  Update ChangeLog.md
  Update package.json
  Update ChangeLog.md
  just do get call to next link for single operation dpg paging (#1307)
  Update ChangeLog.md
  remove lowlevel client test (#1303)
  default to version tolerant (#1304)
  Fix changelog date (#1302)
  hide operations with > 2 body types (#1300)
  update min dependency for `msrest` (#1301)
  remove dpg legacy generation (#1298)
  update flags (#1297)
  Update package.json
  Update ChangeLog.md
  Update ChangeLog.md
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant